Closing the loop when no-mistakes writes code. Use when an ATM PR carries no-mistakes(...) commits or has the review-required label. The CoS makes sure the code is reviewed, then labels the PR review-completed to merge it or pr-discarded to stop it. The CoS launches and verifies; it does not write code.
Install
npx skillscat add thellmwhisperer/agentic-team-member/no-mistakes-review Install via the SkillsCat registry.
Closing the loop when no-mistakes writes code
no-mistakes commits (no-mistakes(review|ci|lint|document|test): ...) do not
go through ponytail or another review in the delivery gate. A PR that has one
merges only through three labels (Decision 7524). There is no unblocking
comment, no check made red by this review and no particular user: the labels
are the circuit. Go checks reports tests and lint.
What the labels do
review-requiredblocks the merge.scripts/arm-auto-merge.shreads
the PR's commits. With anyno-mistakes(...)commit awaiting review it addsreview-requiredand leaves auto-merge disabled. If GitHub
lists fewer commits than the PR has, it fails closed the same way.review-completedallows auto-merge. Adding the label triggers thelabeledevent and arms the merge bound to the head detection read, subject
to the risk rules and required checks.
Whenreview-completedis accepted, the script removesreview-required
if present.- Any push invalidates the review. On
synchronize, a PR with anyno-mistakes(...)commit losesreview-completedand is left unarmed,
even when the new commit is not from no-mistakes. Review covers one head. pr-discardednever merges. Auto-merge never arms it, and disables
auto-merge if it was armed.- A PR with no no-mistakes commits merges as before.
The circuit
- Make sure the code is reviewed. Look at the size of the no-mistakes
commits, leaving out files markedlinguist-generatedin.gitattributes
(currentlygo.sum):git diff --stat <first-nm>^ <head> -- . ':(exclude,attr:linguist-generated)'.
A little code the CoS reviews. A lot of code goes to one agent with the
issue text and the no-mistakes commits
(git log --oneline origin/main..<head> --grep '^no-mistakes(', thengit showof each), which checks every hunk against the issue's
acceptance criteria. - Ponytail pass. Another agent passes the branch with ponytail, removing
bloat: features nobody asked for, new dependencies, speculative
validation, weakened tests. Real work the issue does not ask for becomes a
follow-up issue. - Fine: label it. Once corrected, verify the head is the one reviewed,
addreview-completed, and the PR merges. If anything is pushed after
that, the label goes away: review the new head and add it again. - Not mergeable: discard it. When the review breaks what the issue asks,
or code has to be undone:- add
pr-discarded; - comment on the PR what happened;
- update the issue;
- create what is needed: a relaunch, or a split into smaller tickets.
- add
A push and a label racing each other are settled here, not in code: label
only the head that was reviewed, and check it is still the head afterwards.