Use as a coordinator before giving any branch its landing verdict. Covers the scope check, when to read the diff yourself and when to dispatch a reviewer, what to look for, sending findings back, the three verdicts, follow-up records, preventing a defect class seen twice, and CI changes that only add strictness.
Install
npx skillscat add josiahallard/agentic-project-manager-kit/content-skills-branch-review Install via the SkillsCat registry.
SKILL.md
Coordinator: branch review
No branch reaches the lander without your verdict. Green proves the project still works, not that the change is right, in scope, or exercised.
- Gather the brief, the exact diff range, the author's gate report and log paths;
python <kit>/tools/review_pack.py -C <worktree> <branch>. - Scope check, yourself:
git diff --stat <merge-base>..<branch>against the brief. A file outside scope is a finding before you read a line. - Small (about 150 lines) and low or medium risk: read every hunk yourself (docs and additive content: skim). Larger or high risk: dispatch a fresh, read-only reviewer role, never the author, its tier by the "Reviewer model" rule in skill coordinator-dispatch, roster.md; give it the brief, range, gate report and logs. The verdict stays yours. Standing checks:
python <kit>/tools/doc_index.py -C <worktree> --find review. - Look for: what the brief asked and only that; a test that fails without the change, and that it ran; new failure paths handled, not merely unreachable; a changed public interface, wire format, schema or stored data; a check weakened for green (a gate made green by deleting or loosening a test goes back); inferences marked as inferences; a commit trailer that misnames the host or model.
- A failure is real unless it is on the known-flakes list (
python <kit>/tools/doc_index.py -C <worktree> --find flakes). - Findings go to the author by continuing that agent: numbered, file and symbol, with severity; it fixes and re-runs its gate; you re-review the fix only.
- Small findings are fixed on this branch, never filed as follow-ups, including incidental defects found there (a tool bug, a wrong doc line, a flake fix);
backlog.py addrefuses a record whose scope overlaps the branch. File a follow-up only for work too large or out of scope, and worth doing. - Verdict: LAND; LAND WITH FOLLOW-UP (recorded in the plan); SEND BACK. Give the lander the branch, full main and tip hashes and the reviewed range. A design disagreement goes to the owner, both positions stated fairly.
- A defect class seen twice is prevented in this order: a guard in code (fail-fast check, test, or a script that does the step); else the reference doc owning the area, the incident in the findings or decisions log; only then one instruction line, a rule not a story, if every agent must act on it.
- A CI change that only adds strictness (pass-string grep, test step, assertion) for an approved plan item is ordinary work: review it as High risk and land it.
Never
- Decide from green alone, or review your own implementation.
- Write the repo's instruction files or tracked host config: owner-only; propose. Restate in a profile what the instructions or a reference doc already say.
- Land a check removed, loosened, skipped or made optional without the owner's typed go.
Details: <kit>/docs/review-pack.md; the coordinator role file, "The owner".