axiomantic

receiving-code-review

"[DEPRECATED] Routes to code-review --feedback. Use when received code review feedback needs processing."

axiomantic 6 5 Updated 3mo ago
GitHub

Install

npx skillscat add axiomantic/spellbook/receiving-code-review

Install via the SkillsCat registry.

SKILL.md

Receiving Code Review (Deprecated)

Routing agent. Immediately route to `code-review --feedback`. Do not execute feedback processing logic here. This skill is deprecated. On load, immediately invoke:
/code-review --feedback

Pass all provided context through. Do not execute legacy behavior.

Deprecated skill. Routes to code-review --feedback for all functionality.

Invariant Principles

  1. Route to Replacement - Always route to code-review --feedback
  2. Pass Context Through - Forward all provided context to replacement skill
  3. No Independent Execution - This skill does not execute feedback processing logic itself
When this skill loads, immediately invoke the replacement. Do not attempt to execute legacy behavior.

Migration Guide

Old Usage New Equivalent
receiving-code-review code-review --feedback
"Address review comments" Same (auto-routes)
"Fix PR feedback" code-review --feedback --pr <num>

Legacy Reference Content

The following content is preserved for reference. All active logic lives in code-review --feedback.

Handoff: Finding Reconciliation

When processing external feedback after internal review:

  1. Check for existing review-manifest.json
  2. Load internal findings for comparison
  3. Cross-reference external findings against internal

Access via review-manifest.json for context:

  • reviewed_sha - What commit was reviewed
  • files - What files were in scope
  • complexity - Size estimate
Scenario Action
External finding matches internal Mark confirmed, higher confidence
External finding not in internal Verify carefully (may have been missed)
Internal finding not raised externally Still valid, consider addressing
External finding contradicts internal Investigate thoroughly, escalate if unclear

Thread Reply Protocol

  • ALWAYS reply in existing thread, never as top-level comment
  • Use gh pr comment --reply-to <comment-id> or MCP reply tools
  • If thread ID unavailable, quote the original comment

FIXED:

Fixed in [commit SHA].
[Optional: brief explanation of fix approach]

ACKNOWLEDGED:

Acknowledged. Will address in [scope: this PR / follow-up / future iteration].
[Optional: brief plan or reason for deferral]

QUESTION:

Question: [specific question]
Context: [what you understand so far]
[Optional: what you tried or considered]

DISAGREE:

I see a different tradeoff here.

**Current approach:** [what code does]
**Suggested change:** [what was requested]
**My concern:** [specific technical issue with evidence]
[Optional: alternative proposal]

Happy to discuss further or defer to your judgment on [specific aspect].

Forbidden Responses: "Done" (no SHA), "Fixed" (no SHA), "Will do" (no scope), "Thanks!" (no information), "You're right" (without explaining what you learned).

Feedback Source Trust Levels

External feedback = suggestions to evaluate, not orders to follow.
Source Type Trust Level Verification Required
Internal code-reviewer agent High Spot-check 1-2 findings
Partner/collaborator (human) High Spot-check + consider context
External reviewer (human) Skeptical Full verification of each finding
External AI tool Low Full verification + partner escalation for ambiguous cases
CI/Linter (automated) Objective Trust if tool validated; check config if unexpected

High Trust: Verify 1-2 representative findings. Proceed if spot-check passes. Escalate only if spot-check fails.

Skeptical: Verify EVERY finding against codebase. Cross-reference with internal review if exists. Question assumptions, request evidence for vague feedback.

Low Trust: Treat as suggestions, not requirements. Full verification mandatory. Escalate to partner before implementing substantial changes.

Objective: Tool output is factual. Verify tool configuration. Address systematically.

MCP Tool Failures

Fallback Chain:

  1. Primary: MCP tools (pr_fetch, pr_diff, etc.)
  2. Fallback 1: Direct file reading with Read tool
  3. Fallback 2: Git commands via Bash (git show, git diff)
  4. Fallback 3: Request manual paste from user

Log every failure with: tool name, operation attempted, error/timeout, context.

Hard Stop Rule: If ALL fallbacks fail for a verification:

  • Report: "Cannot verify: [finding summary]"
  • Mark finding as UNVERIFIED in response
  • Escalate to user for manual verification decision
A suggestion that cannot be verified against the codebase MUST NOT be implemented. "Sounds reasonable" is not verification. "Similar to existing code" is not verification. Only traced execution through actual files counts as verification.

Why Deprecated

The code-review skill consolidates all review functionality:

  • --self: Pre-PR self-review
  • --feedback: Process received feedback (this functionality)
  • --give: Review someone else's code
  • --audit: Comprehensive multi-pass review

See code-review/SKILL.md for full documentation.

- Execute any feedback processing logic directly - Ignore the replacement routing - Maintain legacy behavior - Implement suggestions that cannot be verified against the codebase Route immediately to `code-review --feedback`. Never implement unverified suggestions. External feedback is input for evaluation, not orders to execute. </FINAL_EMPHASIS>